+- Jellyfin Forum (https://forum.jellyfin.org)
+-- Forum: Support (https://forum.jellyfin.org/f-support)
+--- Forum: General Questions (https://forum.jellyfin.org/f-general-questions)
+--- Thread: HDR Info passed to Kodi (/t-hdr-info-passed-to-kodi)
RE: HDR Info passed to Kodi - olevelo - 2024-01-09
(2024-01-08, 11:19 AM)fezster Wrote: Thanks for pointing that out! I've fixed the indentation error. That'll teach me for trying to do these updates in a browser, rather than using a proper development evironment.
How did it run in testing like that? Usually it would fail with an indentation error like that.
RE: HDR Info passed to Kodi - fezster - 2024-01-09
(2024-01-09, 12:27 AM)olevelo Wrote:(2024-01-08, 11:19 AM)fezster Wrote: Thanks for pointing that out! I've fixed the indentation error. That'll teach me for trying to do these updates in a browser, rather than using a proper development evironment.
How did it run in testing like that? Usually it would fail with an indentation error like that.
Im not really a python developer, nor have I used github.com before. So I was manually making the changes and editing them on the web. This was a copy/paste error. I've now installed Github desktop and a python IDE so I dont make that mistake again.
RE: HDR Info passed to Kodi - Adam86 - 2024-01-09
Just recently switched from PlexKodiConnect to JellyFin for my home setup & noticed the HDR Flags were missing when viewing my library listings & came across this topic.
So it is nice to see that this has been worked on.
Is there a new Jellyfin Plugin that will feature this functionalilty coming out soon, or is there a way for me to be on cutting edge features?
Whilst I am at it, I'm guessing that proper compatibility with Kodi 21 will be coming at some point down the line?
RE: HDR Info passed to Kodi - tmsrxzar - 2024-01-09
(2024-01-09, 12:08 PM)Adam86 Wrote: Is there a new Jellyfin Plugin that will feature this functionalilty coming out soon
not until the PR is merged https://github.com/jellyfin/jellyfin-kodi/pull/804 (current state open means not in main code)
(2024-01-09, 12:08 PM)Adam86 Wrote: or is there a way for me to be on cutting edge features?
add the changes from the PR to your local version of the addon, it's just plain text python https://github.com/jellyfin/jellyfin-kodi/pull/804/files
(2024-01-09, 12:08 PM)Adam86 Wrote: Whilst I am at it, I'm guessing that proper compatibility with Kodi 21 will be coming at some point down the line?
what exactly is incompatible? works fine on 21 for me and has been for not less than 6 months
RE: HDR Info passed to Kodi - Adam86 - 2024-01-09
(2024-01-09, 02:52 PM)tmsrxzar Wrote: add the changes from the PR to your local version of the addon, it's just plain text python https://github.com/jellyfin/jellyfin-kodi/pull/804/files
Great, I'll take a look at doing this in the meantime :-)
(2024-01-09, 02:52 PM)tmsrxzar Wrote: what exactly is incompatible? works fine on 21 for me and has been for not less than 6 months
Well I generally use CoreELEC CE21 Nightlies, it was working from the 020124 build, but last nights 080124 build the Movies section was showing completely empty, and when I did a bit of digging it looks like Team KODI have upped their database schema up to 129 now.
Cheers
RE: HDR Info passed to Kodi - tmsrxzar - 2024-01-09
(2024-01-09, 03:23 PM)Adam86 Wrote: Well I generally use CoreELEC CE21 Nightlies, it was working from the 020124 build, but last nights 080124 build the Movies section was showing completely empty, and when I did a bit of digging it looks like Team KODI have upped their database schema up to 129 now.
ah, one of those penalties for running the latest bleeding edge before the devs
probably needs a resync to jellyfin if the database went from 121 to 129 but did not migrate the database
if not then downgrade to the last nightly that worked and wait for the jellyfin devs to catch up
afaik the addon pulls the version from the database but if it doesn't know where to find that database (because it thinks 21 should be 121) then there's not going to be any way
btw if you're not aware the addon directly interacts with the database instead of with kodi itself
RE: HDR Info passed to Kodi - Adam86 - 2024-01-09
(2024-01-09, 03:37 PM)tmsrxzar Wrote:(2024-01-09, 03:23 PM)Adam86 Wrote: Well I generally use CoreELEC CE21 Nightlies, it was working from the 020124 build, but last nights 080124 build the Movies section was showing completely empty, and when I did a bit of digging it looks like Team KODI have upped their database schema up to 129 now.
ah, one of those penalties for running the latest bleeding edge before the devs
probably needs a resync to jellyfin if the database went from 121 to 129 but did not migrate the database
if not then downgrade to the last nightly that worked and wait for the jellyfin devs to catch up
afaik the addon pulls the version from the database but if it doesn't know where to find that database (because it thinks 21 should be 121) then there's not going to be any way
btw if you're not aware the addon directly interacts with the database instead of with kodi itself
Yeah I tried the usual resync and clear out the databases etc but Movies came back empty again, even though sync process showed all the films it was churning through, TV Series was fine though.
I reverted back and all was good again.
Yeah fully understood on the process how the addon works - used PlexKodiConnect for best part of a year, but that stopped working several weeks ago with the database schema bumps, and the dev for that addon doesn't seem to be around for a long time.
RE: HDR Info passed to Kodi - mcarlton00 - 2024-01-09
Full disclaimer: we typically don't do much work towards the next kodi version until at least betas, because things still regularly change and it's just downright exhausting trying to keep up with whatever upstream is doing. If you want to open an issue on the repo about the database schema version change that would be a great help to reminding me to look at it once I get some time freed up to do some dev work around here. iirc it's a super trivial change in the addon (assuming no other big schema changes), but it's been a while since I was last in that section of the code.
RE: HDR Info passed to Kodi - olevelo - 2024-01-09
(2024-01-09, 11:54 AM)fezster Wrote:(2024-01-09, 12:27 AM)olevelo Wrote:(2024-01-08, 11:19 AM)fezster Wrote: Thanks for pointing that out! I've fixed the indentation error. That'll teach me for trying to do these updates in a browser, rather than using a proper development evironment.
How did it run in testing like that? Usually it would fail with an indentation error like that.
Im not really a python developer, nor have I used github.com before. So I was manually making the changes and editing them on the web. This was a copy/paste error. I've now installed Github desktop and a python IDE so I dont make that mistake again.
Ah gotcha.
(2024-01-09, 05:05 PM)mcarlton00 Wrote: Full disclaimer: we typically don't do much work towards the next kodi version until at least betas, because things still regularly change and it's just downright exhausting trying to keep up with whatever upstream is doing. If you want to open an issue on the repo about the database schema version change that would be a great help to reminding me to look at it once I get some time freed up to do some dev work around here. iirc it's a super trivial change in the addon (assuming no other big schema changes), but it's been a while since I was last in that section of the code.
For what it's worth, Kodi is on Beta 2 right now.
RE: HDR Info passed to Kodi - tmsrxzar - 2024-01-09
(2024-01-09, 05:05 PM)mcarlton00 Wrote: Full disclaimer: we typically don't do much work towards the next kodi version until at least betas, because things still regularly change and it's just downright exhausting trying to keep up with whatever upstream is doing. If you want to open an issue on the repo about the database schema version change that would be a great help to reminding me to look at it once I get some time freed up to do some dev work around here. iirc it's a super trivial change in the addon (assuming no other big schema changes), but it's been a while since I was last in that section of the code.
the detection function here https://github.com/jellyfin/jellyfin-kodi/blob/master/jellyfin_kodi/database/__init__.py#L99
still works for me "Discovered database: {'db_file': 'MyVideos129.db', 'version': 129}"
so there's something else going on and the issue report does need to be added with a complete debug log
for myself, i am happy to hold back on nightlies until jellyfin is ready
(the above detection was just me making a copy of 121 to 129 to see if it would detect 129, i am not running 129)