+- Jellyfin Forum (https://forum.jellyfin.org)
+-- Forum: Support (https://forum.jellyfin.org/f-support)
+--- Forum: General Questions (https://forum.jellyfin.org/f-general-questions)
+--- Thread: Jellyfin for Tizen official app: How to disable Smooth Scrolling? (/t-jellyfin-for-tizen-official-app-how-to-disable-smooth-scrolling)
Pages:
1
2
RE: Jellyfin for Tizen official app: How to disable Smooth Scrolling? - raulo1985 - 2024-12-19
(2024-10-08, 07:44 PM)TheDreadPirate Wrote: My understanding is that is just for web browsing on the TV so that when you scroll down a page it is animated instead of "skipping" as you scroll. It has no functional purpose.
Hi:
Sorry to revive this thread, but since I wanted to modify a couple of things on jellyfin-web for my server (so I had to modify the code anyway), I decided to modify the smoothscroll line that you said (in the scrollManager.js file. Although apparently the current state of that file is that smooth scroll is no longer enabled by default only on Tizen clients, but I replaced the line for "return false" anyway).
I have yet to test the UI performance on my relative's Samsung Smart TV after I built jellyfin-web from source with that line modified, but I have a question on that regard. In the appSettings.js file (src/scripts/settings), there's also some code related to smooth scrolling, and looks like it enables smooth scroll on Tizen clients:
Code:
/**
* Get or set 'Enable smooth scroll' state.
* @param {boolean|undefined} val - Flag to enable 'Enable smooth scroll' or undefined.
* @return {boolean} 'Enable smooth scroll' state.
*/
enableSmoothScroll(val) {
if (val !== undefined) {
return this.set('enableSmoothScroll', val.toString());
}
return toBoolean(this.get('enableSmoothScroll'), !!browser.tizen);
}Should I modify both files (scrollManager.js and appSettings.js) for smooth scroll to be disabled by default on all clients (including Tizen)? If so, should I replace "!!browser.tizen" with "false"?
Thanks again!
RE: Jellyfin for Tizen official app: How to disable Smooth Scrolling? - TheDreadPirate - 2024-12-20
I honestly have no idea.
RE: Jellyfin for Tizen official app: How to disable Smooth Scrolling? - raulo1985 - 2024-12-21
(2024-12-20, 03:24 PM)TheDreadPirate Wrote: I honestly have no idea.
Thanks for your honest reply
Guess it wouldn’t hurt to modify that line too. Since I’m clearly not at expert at coding, what I should do is to replace that “!!browser.tizen” line with “return false”? That would be the correct syntax (even if we don’t know the real impact of modifying that line)?
Still weird that the line at scrollManager.js was modified at some point and it no longer mentions only Tizen clients for Smooth Scroll to be enabled by default, but at the same time only Tizen client is mentioned in appSetting.js when talking about Smooth Scroll. Perhaps the last one doesn’t do anything, but I guess it’s better to make sure and return false it (but without breaking things because of bad syntax). Is it correct to replace !!browser.tizen with return false from a coding/syntax point of view?