+- Jellyfin Forum (https://forum.jellyfin.org)
+-- Forum: Support (https://forum.jellyfin.org/f-support)
+--- Forum: General Questions (https://forum.jellyfin.org/f-general-questions)
+--- Thread: HDR Info passed to Kodi (/t-hdr-info-passed-to-kodi)
HDR Info passed to Kodi - Swindiff - 2023-12-28
Hi
I use Jellyfin for my Backend server and the Jellyfin for Kodi addon as my clients on my Android Boxes. I use Aeon Nox Silvo skin in Kodi, a new addition is being able to show the HDR Flag for files which are HDR. But I have noticed that all my files are showing as SDR. I have posted on the Kodi forum for the Silvo skin and the suggestion is that maybe Jellyfin is not passing the HDR data to Kodi in a way that allows the flags to be shown correctly.
Here is a link to my post on the forum with some of the replies from the skin author.
https://forum.kodi.tv/showthread.php?tid=210069&pid=3177090#pid3177090
Just wondering if this is the case, and is it something that could be easily implemented.
Cheers
RE: HDR Info passed to Kodi - TheDreadPirate - 2023-12-29
Interesting. The web client states in the "video" line that it detects that it is HDR. But when I look in the Android TV client there is no HDR tag. So I'm assuming that is what you are also not seeing in Kodi.
RE: HDR Info passed to Kodi - tmsrxzar - 2023-12-29
you went a long way to find out "this is not supported by the jellyfin for kodi addon"
the kodi skin in question is using hdrtype which is filled in by kodi from the streamdetails table of the database
https://github.com/MikeSiLVO/skin.aeon.nox.silvo/blob/master/16x9/Variables.xml#L1680
but the jellyfin for kodi addon never inserts anything into that field and all entries are "NULL" in the database
https://github.com/jellyfin/jellyfin-kodi/blob/master/jellyfin_kodi/objects/kodi/queries.py
a quick grep of the jellyfin for kodi addon shows no reference to "hdrtype" what-so-ever
in summary there is no way for the skin to know it's hdr type is dolby vision/hdr/hdr10 when it's not in the database
raise an issue with the addon on github https://github.com/jellyfin/jellyfin-kodi/issues
RE: HDR Info passed to Kodi - fezster - 2024-01-04
This was bothering me so I fixed it. I dont really do open source coding but I created a PR for the changes required (all quite straightforward):
https://github.com/jellyfin/jellyfin-kodi/pull/804
RE: HDR Info passed to Kodi - tmsrxzar - 2024-01-04
thanks for that fezster
RE: HDR Info passed to Kodi - segovid - 2024-01-05
(2024-01-04, 05:41 PM)fezster Wrote: This was bothering me so I fixed it. I dont really do open source coding but I created a PR for the changes required (all quite straightforward):
https://github.com/jellyfin/jellyfin-kodi/pull/804
Thank you so much! Do you think you could also get the 'Dolby Atmos' information passed to Kodi as well ?
RE: HDR Info passed to Kodi - olevelo - 2024-01-07
(2024-01-04, 05:41 PM)fezster Wrote: This was bothering me so I fixed it. I dont really do open source coding but I created a PR for the changes required (all quite straightforward):
https://github.com/jellyfin/jellyfin-kodi/pull/804
It's unfortunate that the auto code checks are failing against pre-existing code! Hope an admin can go in and approve it quickly. I looked at the code and seemed pretty straightforward.
RE: HDR Info passed to Kodi - mcarlton00 - 2024-01-07
Code:
./jellyfin_kodi/helper/api.py:74:27: E999 IndentationError: unindent does not match any outer indentation level
1 E999 IndentationError: unindent does not match any outer indentation level
1I haven't had time to actually look into things yet, but this is most definitely not failing on pre-existing code. It's a bad change introduced in the PR
RE: HDR Info passed to Kodi - olevelo - 2024-01-07
(2024-01-07, 01:04 AM)mcarlton00 Wrote:Code:./jellyfin_kodi/helper/api.py:74:27: E999 IndentationError: unindent does not match any outer indentation level
1 E999 IndentationError: unindent does not match any outer indentation level
1
I haven't had time to actually look into things yet, but this is most definitely not failing on pre-existing code. It's a bad change introduced in the PR
You're right, that line is 1 character off, can see it in the commit diff. I was looking at others like the first error which seems to point to line 1, but there's no changes there. But maybe the error checker just isn't showing the right line number.
RE: HDR Info passed to Kodi - fezster - 2024-01-08
Thanks for pointing that out! I've fixed the indentation error. That'll teach me for trying to do these updates in a browser, rather than using a proper development evironment.
(2024-01-05, 02:55 AM)segovid Wrote:(2024-01-04, 05:41 PM)fezster Wrote: This was bothering me so I fixed it. I dont really do open source coding but I created a PR for the changes required (all quite straightforward):
https://github.com/jellyfin/jellyfin-kodi/pull/804
Thank you so much! Do you think you could also get the 'Dolby Atmos' information passed to Kodi as well ?
I had a look at this today. It doesnt look like Atmos is supported in the media codec info. Estuary skin has no icon/label for it.
Some skins (eg. Aeon Silvo) use the filename to detect Atmos and other 3d audio codecs.