+- Jellyfin Forum (https://forum.jellyfin.org)
+-- Forum: Development (https://forum.jellyfin.org/f-development)
+--- Forum: Server Development (https://forum.jellyfin.org/f-server-development)
+--- Thread: Subtitle format support / ffmpeg fallback between install and code (/t-subtitle-format-support-ffmpeg-fallback-between-install-and-code)
Subtitle format support / ffmpeg fallback between install and code - theshoeshiner - 2023-09-05
I have an official jellyfin install, as well as a local version of the git repo, and I cant figure out the difference between the two in regards to subtitle parsing.
It looks like in SubtitleEncoder.cs, it falls back to ffmpeg encoding if the Nikse subtitle library doesnt support the format. This is what's happening in my installed version for .sub files (Not sure why, because Nikse has a SubViewer parser). However my dev version, running directly off the git repo, appears to find the Nikse parser class and uses it. What is causing the official build to fallback to ffmpeg instead of Nikse?
Logs confirm the installed version is using ffmpeg in the logs...
Code:
[2023-09-05 12:27:35.451 -04:00] [DBG] [71] MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder: charset "ascii" detected for "F:\Downloads\Test\f1153920.eng.sub"
[2023-09-05 12:27:35.470 -04:00] [INF] [71] MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder: "ffmpeg.exe" " -sub_charenc ascii -i \"F:\Downloads\Test\f1153920.eng.sub\" -c:s srt \"G:\servers\jellyfin\data\data\subtitles\f\fe4470d6-b53e-6863-f060-0f5045fc06ea.srt\""
[2023-09-05 12:27:35.604 -04:00] [INF] [18] MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder: Setting ass font within "G:\servers\jellyfin\data\data\subtitles\f\fe4470d6-b53e-6863-f060-0f5045fc06ea.srt"
[2023-09-05 12:27:35.611 -04:00] [INF] [59] MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder: ffmpeg subtitle conversion succeeded for "F:\Downloads\Test\f1153920.eng.sub"
[2023-09-05 12:27:35.614 -04:00] [DBG] [59] MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder: charset "ascii" detected for "G:\servers\jellyfin\data\data\subtitles\f\fe4470d6-b53e-6863-f060-0f5045fc06ea.srt"And the dev version running off the git repo uses Nikse...
Code:
[12:40:21] [WRN] [19] MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder: GetReadableFile
[12:40:21] [DBG] [19] MediaBrowser.MediaEncoding.Subtitles.SubtitleEncoder: charset ascii detected for E:\Workspaces\jellyfin-dev\media-library\f1153920.eng.sub
[12:40:21] [WRN] [16] MediaBrowser.MediaEncoding.Subtitles.SubtitleEditParser: Trying to parse 'sub' subtitle using the DVDSubtitle format parser