Desktop-Entry Icon Bug on Linux Client

[M4dMike]

Hi,

I am new to Jellyfin and after setting up a small Server Instance the next Step was a Client on my Ubuntu Desktop Machine.
This Method from the official Site was used: https://flathub.org/apps/com.github.iwal...dia-player

I noticed that after clicking on the Icon to start the client after pinning it on my Dash there was showing up a new Intsance of Jellyfin with a generic Icon.
Since i was familiar with creating custom Desktop Entries i was able to fix this Behavior, i will describe how at the End.
Can someone please pick this up and report it on Github or point me to right place so that i can do it myself?
(Sorry i don' have much experience in this at all, development, git, flatpak and so on...)

Thanks a lot, Mike


Problem/Fix:

1. Without Modification Jellyfin Ubuntu Client starts in Dash as  new Instance without Icon
2. Deskop-Entry gets created in "/usr/share/applications" and is named "com.github.iwalton3.jellyfin-media-player.desktop"
3. Following Specification-Line is wrong: "StartupWMClass=com.github.iwalton3.jellyfin-media-player"
4. The Command "xprop | grep WM_CLASS" in Terminal and clicking on the Jellyfin Window delivers the actual WMClass: "WM_CLASS(STRING) = "jellyfinmediaplayer", "Jellyfin Media Player""
5. Changing this in the Desktop-Entry solves the Problem: "StartupWMClass=jellyfinmediaplayer"

[TheDreadPirate]

HUZZAH! I've been wondering about this for a while. I submitted a PR with your change.

https://github.com/jellyfin/jellyfin-med...r/pull/771

[M4dMike]

Thanks a lot, for the PR and for the credits.
I was already curious if I am the only one ^^'

By the way, here is the best Resource on Desktop Entries I could find, it also had the Instruction on how to check out the actual WM_CLASS.
https://wiki.ubuntuusers.de/.desktop-Dat...-bestimmen
(Its German but also am I, and nowadays there are online Translators if your really need them...)

Now I am eager to see if it gets easily approved and wonder how long it will take until the change goes online =D



Edit: forgot Link...