Quote:lib /def:mpv\mpv.def /out:mpv\mpv.dll.lib /MACHINE:X64

Quote:fatal error LNK1104 (and it says it can't open the 'mpv\libmpv-2.dll.lib' file).

Quote:LNK4272 warnings: library machine type 'x64' conflicts with target machine type 'X86'.

(2024-12-13, 12:01 AM)raulo1985 Wrote: [...](on x64_x86 Cross Tools of VS 2022)[...]

Quote:lib /def:mpv\mpv.def /out:mpv\mpv.dll.lib /MACHINE:X64
LNK4272 warnings: library machine type 'x64' conflicts with target machine type 'X86'.

Quote:PS: on a side note, I can only get to that point with older  versions of libmpv1, because newer ones don't include a mpv.def file, which is required apparently. How can I try with a newer libmpv1 version without the mpv.def file? Or you can just use one that came with an older version?

(2024-12-13, 06:51 AM)qwerty12 Wrote: I've never built JMP from source, so take what you will from this.

(2024-12-13, 12:01 AM)raulo1985 Wrote: [...](on x64_x86 Cross Tools of VS 2022)[...]

Quote:lib /def:mpv\mpv.def /out:mpv\mpv.dll.lib /MACHINE:X64
LNK4272 warnings: library machine type 'x64' conflicts with target machine type 'X86'.

Well, which is it: are you trying to cross-compile a 32-bit build of JMP on a 64-bit machine, or do you actually want a 64-bit build of JMP? If it's the former, I'd start by changing /MACHINE:X64 and if it's the latter, you should be running "x64 Native Tools Command Prompt for VS 2022" instead.

Quote:PS: on a side note, I can only get to that point with older  versions of libmpv1, because newer ones don't include a mpv.def file, which is required apparently. How can I try with a newer libmpv1 version without the mpv.def file? Or you can just use one that came with an older version?

Look at the workflow file for JMP. You'll notice it runs gendef as part of the build process to produce a def file from a given libmpv.dll. If you want a copy of that program, you can take an executable from here: https://packages.msys2.org/packages/mingw-w64-x86_64-tools-git

(2024-12-14, 02:37 PM)raulo1985 Wrote: Thanks for your reply, greatly appreciate it. I'm trying to create a x64 build, I used Cross tools because that's what the instructions said. When I use x64 Native Tools Command Prompt for VS 2022 I get many "PlayerComponent.cpp.obj : error LNK2019: unresolved external symbol" messages (related to mpv) and it ends with a fatal error. So I'm still stuck.

1. I ran "x64 Native Tools Command Prompt for VS 2022"
   
2. Cloned the code: git clone --single-branch --branch master https://github.com/jellyfin/jellyfin-media-player.git
   
3. cd jellyfin-media-player && mkdir build && cd build
   
4. I downloaded and extracted https://github.com/shinchiro/mpv-winbuild-cmake/releases/download/20241215/mpv-dev-x86_64-20241215-git-e52f975.7z into jellyfin-media-player\build\mpv
   
5. I extracted gendef.exe from https://mirror.msys2.org/mingw/mingw64/mingw-w64-x86_64-tools-git-12.0.0.r446.ga2d19218d-1-any.pkg.tar.zst (WinRAR/7-Zip), placed it into jellyfin-media-player\build\mpv and ran gendef libmpv-2.dll
   
6. From the jellyfin-media-player\build folder, I ran cmake -GNinja -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=output -DCMAKE_MAKE_PROGRAM=ninja.exe -DQTROOT=C:/Qt/5.15.2/msvc2019_64 -DMPV_INCLUDE_DIR=mpv/include -DMPV_LIBRARY=mpv/libmpv-2.dll -DCMAKE_INSTALL_PREFIX=output ..
   
7. I ran lib /def:mpv\libmpv-2.def /out:mpv\libmpv-2.dll.lib /MACHINE:X64
   
8. I finally ran ninja and got a src\JellyfinMediaPlayer.exe for my troubles
   
9. Running it failed; I had to run set "PATH=C:\Qt\5.15.2\msvc2019_64\bin;%PATH%" so the Qt DLLs are found and copy mpv\libmpv-2.dll src\ for src\JellyfinMediaPlayer.exe to start
   

(2024-12-15, 01:07 PM)qwerty12 Wrote:

(2024-12-14, 02:37 PM)raulo1985 Wrote: Thanks for your reply, greatly appreciate it. I'm trying to create a x64 build, I used Cross tools because that's what the instructions said. When I use x64 Native Tools Command Prompt for VS 2022 I get many "PlayerComponent.cpp.obj : error LNK2019: unresolved external symbol" messages (related to mpv) and it ends with a fatal error. So I'm still stuck.

I did manage to build it on my system (although I didn't then carry on with the instructions for building an installer) by following the steps from the automated workflow used by JMP that I linked in my previous post and the README. I have no idea how your system is configured and what steps you've followed (and omitted), but I can go through what I did with a clean tree in the hopes it may help you. If you started building a 32-bit build and are now switching to produce a 64-bit build, I'd start by cleaning the build folder.

I already had CMake and Ninja installed via Scoop, so they were already the latest versions and were in my %PATH%. Git for Windows was installed, of course. I did have to install Qt's 5.15.2 Qt WebEngine and MSVC 2019 64-bit from Qt's installer (username and password taken from BugMeNot).

---

1. I ran "x64 Native Tools Command Prompt for VS 2022"
   
2. Cloned the code: git clone --single-branch --branch master https://github.com/jellyfin/jellyfin-media-player.git
   
3. cd jellyfin-media-player && mkdir build && cd build
   
4. I downloaded and extracted https://github.com/shinchiro/mpv-winbuild-cmake/releases/download/20241215/mpv-dev-x86_64-20241215-git-e52f975.7z into jellyfin-media-player\build\mpv
   
5. I extracted gendef.exe from https://mirror.msys2.org/mingw/mingw64/mingw-w64-x86_64-tools-git-12.0.0.r446.ga2d19218d-1-any.pkg.tar.zst (WinRAR/7-Zip), placed it into jellyfin-media-player\build\mpv and ran gendef libmpv-2.dll
   
6. From the jellyfin-media-player\build folder, I ran cmake -GNinja -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=output -DCMAKE_MAKE_PROGRAM=ninja.exe -DQTROOT=CQt/5.15.2/msvc2019_64 -DMPV_INCLUDE_DIR=mpv/include -DMPV_LIBRARY=mpv/libmpv-2.dll -DCMAKE_INSTALL_PREFIX=output ..
   
7. I ran lib /def:mpv\libmpv-2.def /out:mpv\libmpv-2.dll.lib /MACHINE:X64
   
8. I finally ran ninja and got a src\JellyfinMediaPlayer.exe for my troubles
   
9. Running it failed; I had to run set "PATH=C:\Qt\5.15.2\msvc2019_64\bin;%PATH%" so the Qt DLLs are found and copy mpv\libmpv-2.dll src\ for src\JellyfinMediaPlayer.exe to start
   

Now, the actual loading of JMP fails - I imagine it's looking for some resource or for more (QtWebEngine) DLLs to load at runtime l that I need to copy from elsewhere (presumably the steps to create an installer bundles everything together) - but it did build for a 64-bit system, on a 64-bit machine, using the latest 64-bit libmpv dll from shinchiro:

(2024-12-17, 11:16 PM)raulo1985 Wrote: But the thing is that I'm trying to create an installer (like the official ones), specially if you say that probably by doing so it would bundle everything together, including the missing resources. That's where I get stuck, I'm trying to figure how to create an installer.

qwerty12 dateline='[url=tel:1734554765' Wrote: 1734554765[/url]']

raulo1985 dateline='[url=tel:1734477395' Wrote: 1734477395[/url]']
But the thing is that I'm trying to create an installer (like the official ones), specially if you say that probably by doing so it would bundle everything together, including the missing resources. That's where I get stuck, I'm trying to figure how to create an installer.

I'm not at all familiar with programs used for creating installers, let alone the specific installer workflow employed by JMP, so there's not really much I can suggest. From a quick look at the README and the workflow file again, you're meant to install WiX Toolset v3.11.2, and then after successfully building with ninja (as you have done) you're meant to run set PATH=%PATH%;C:\Program Files (x86)\WiX Toolset v3.11\bin;%CD% and ninja windows_package which, hopefully, churns out an installer. I think that process may require Python to be installed.

However, that probably won't work without this first: because the program depends on the Microsoft Visual C++ 2015-2022 Redistributable, you need to download that separately and have that as a part of the installer. You can see that being done here: https://github.com/jellyfin/jellyfin-media-player/blob/master/.github/workflows/main.yml#L79-L80
Looking at that, I'm confused as to what practical purpose that sed invocation serves. Maybe it's some WiX thing that I'm unfamiliar with. You can try running that, I guess, but I'd start by simply trying to save https://aka.ms/vs/17/release/vc_redist.x64.exe as bundle/win/Bundle.wxs

I don't actually know if there's any basis for what I said regarding as to why it won't start. To check, install the usual Jellyfin Media Player from its installer and then replace JellyfinMediaPlayer.exe and the libmpv-2.dll in C:\Program Files\Jellyfin Media Player (or wherever it actually installs to) with the ones you built and see if that starts.

---

(Looking at your other thread, if this is to autofill the server address, username and password, I reckon you would have an easier time trying something like modifying web-client\extension\find-webclient.js instead and just having the recipient install the usual Jellyfin Media Player instead and creating a self-extracting 7-Zip archive that will replace the existing find-webclient.js. Or, if JMP saves the credentials in plaintext, a script that just writes out an initial config file. Dunno.)

(2024-12-21, 12:51 AM)raulo1985 Wrote: - When you say save vc_redist.x64.exe as bundle/win/Bundle.wxs, do you mean renaming the .exe file and its extension to Bundle.wxs? Sorry for the noob question.

Quote:- Regarding your last paragraph, I actually want to learn how to modify all the client settings defaults (specially with Tizen client, JMP and WebOS client) so I can remotely install everything by myself and not rely on my relatives tech abilities to do it (it takes too much time, and still somehow they usually end up with a bad configured client). So I’m interested on modifying every setting that you can modify when going to your profile pic at your client (playback, subtitles, even the order of how the libraries are shown if possible, etc). I’ve successfully build and deploy clients for Tizen TVs and WebOS TVs, but haven’t found a way to modify those defaults. Like I mentioned on my other thread, I found that in the appSettings.js and userSettings.js files almost all those settings are mentioned, but I don’t know much about coding so I’ll probably break everything if I modify those files without some assistance/guidance.

Quote:But one thing that could be also useful for this purpose is what you said, to have the server’s ip/ddns/username/password already set up so the client not only has its defaults already configured after installation/deployment, but also automatically logs in to the server without having to type the username and password. How can that be done? What should I modify in the find-webclient.js file for that purpose?

Quote:At least when I look into that file of my already installed and configured JMP, I don’t see anything that mentions or points to my server (and when I execute the program, it automatically logs in).

Quote:In other words, I don’t know what to modify on a client before building it so, after being installed, it auto logs in to my server so the person at the client side don’t have to do, hopefully, anything after deployment (if that’s possible of course).