2024-02-05, 09:59 PM
(This post was last modified: 2024-02-07, 02:03 AM by 1hitsong. Edited 1 time in total.)
Goal
Give admin users a way to search for remote subtitles, select and download the one they want, and delete ones they don't want.
Context
I'll break this update into several chunks.
2/6/2024
PR opened: https://github.com/jellyfin/jellyfin-roku/pull/1694
2/5/2024
Non-admin users see the movie detail view as it is today with no changes.
Admin users see a new button on the movie detail view, Edit Subtitles.
Clicking the Edit Subtitles button takes the user to the new subtitle view. The 2 functions of this view are to search for new subtitles, and manage your current subtitles.
On the left side, users can choose the language they want to search for. This value defaults to their Preferred subtitle language (set in the server settings).
Clicking the Search button searches configured remote subtitle providers (set in the server settings) and shows the found results to the user.
From the search results popup, if the user presses OK, the selected subtitle is downloaded to the server. If the user presses Cancel, the popup closes and nothing is downloaded.
There isn't a good way to know when the subtitle file is downloaded, processed by the server, and provided by the API. So we simply add a blurb of text indicating we're downloading, and the user will need to refresh the view to see if it's now available. This is as simple as pressing back and clicking the Edit Subtitles button again.
The My Subtitles section shows all found subtitles, even those that and embedded in the video. Users can move the cursor over to this section and view the list of subtitles. External subtitle files can be deleted from this location. We indicate the ones that can be deleted by showing a red trashcan icon when selected. Embedded subtitles will not have this icon and are not eligible for deletion.
If the user presses ok while hovering over a subtitle with a trash icon, we show them a deletion confirmation. This confirmation default to No, Cancel. If No is selected, the popup closes and nothing is deleted. If Yes is selected, the subtitle is removed from the My Subtitles section, and is deleted from the file system.
Please post any questions, thoughts, ideas, and any other feedback.
Give admin users a way to search for remote subtitles, select and download the one they want, and delete ones they don't want.
Context
I'll break this update into several chunks.
- Core functionality for movies only <-- I am here
- Redesign movie detail page to improve UX
- Add capability for TV episodes
2/6/2024
PR opened: https://github.com/jellyfin/jellyfin-roku/pull/1694
2/5/2024
Non-admin users see the movie detail view as it is today with no changes.
Admin users see a new button on the movie detail view, Edit Subtitles.
Clicking the Edit Subtitles button takes the user to the new subtitle view. The 2 functions of this view are to search for new subtitles, and manage your current subtitles.
On the left side, users can choose the language they want to search for. This value defaults to their Preferred subtitle language (set in the server settings).
Clicking the Search button searches configured remote subtitle providers (set in the server settings) and shows the found results to the user.
From the search results popup, if the user presses OK, the selected subtitle is downloaded to the server. If the user presses Cancel, the popup closes and nothing is downloaded.
There isn't a good way to know when the subtitle file is downloaded, processed by the server, and provided by the API. So we simply add a blurb of text indicating we're downloading, and the user will need to refresh the view to see if it's now available. This is as simple as pressing back and clicking the Edit Subtitles button again.
The My Subtitles section shows all found subtitles, even those that and embedded in the video. Users can move the cursor over to this section and view the list of subtitles. External subtitle files can be deleted from this location. We indicate the ones that can be deleted by showing a red trashcan icon when selected. Embedded subtitles will not have this icon and are not eligible for deletion.
If the user presses ok while hovering over a subtitle with a trash icon, we show them a deletion confirmation. This confirmation default to No, Cancel. If No is selected, the popup closes and nothing is deleted. If Yes is selected, the subtitle is removed from the My Subtitles section, and is deleted from the file system.
Please post any questions, thoughts, ideas, and any other feedback.
🤘 Enjoy