2024-05-28, 01:42 PM
(2024-05-28, 07:30 AM)M0RPH3US Wrote:(2024-05-27, 02:05 PM)ZestyJelly Wrote:(2024-05-27, 03:29 AM)SmileRapVEVO Wrote: I have seen that when you put it in TV mode it does not work and it does not come out with the expected design.
Yeah, I will get to tweaking it soon. But I don't have a 4K screen to test it on. So unsure how it will end up looking tbh.
I found a bug. When you are using the web player in a mobile device, in landscape orientation the mainDrawer seems to peek out as shown in the attached picture. Managed to solve it using below snippet. I don't know if there is a cleaner way of doing this, but this solves it.ย
Code:/* Portrait orientation */
@media only screen and (orientation: portrait) {
ย .layout-mobile .mainDrawer {
ย ย width: 65% !important;
ย }
}
/* Landscape orientation */
@media only screen and (orientation: landscape) {
ย .layout-mobile .mainDrawer {
ย ย width: 30% !important;
ย }
}
I just literally merged a PR fixing this. The fix was just using a 315px instead of 65%. Unsure if your fix is better than the one I just merged, but let me know if it doesn't fix it for you.
I never use the JF mobile client in landscape mode, so I never saw this. I noticed other things break like the image at the top becomes very small. Your proposed fix gave me an idea of how to try to fix it. I will look into it when I have some time. Thanks.