TMDb Box Sets ignoring "minimum number of movies" setting

[tompw]

I have the TMDb Box Sets plug-in, with "minimum number of movies" set to three. For collections with 3 or more movies, everything works fine. The issue is that is creates collections with just 2 movies (despite the setting), and then those collections don't have images or metadata.
It's like the plugin creates the folder in\Jellyfin\Server\data\collections\ (which JellyFun server then picks up on), but then doesn't do anything with it because it has too few items.


Example of the relevant log entries (after I added The Bourne Identity and later The Bourne Supremacy):

[2024-07-17 10:16:51.368 -04:00] [INF] [8] Jellyfin.Plugin.TMDbBoxSets.TMDbBoxSetManager: Minimum number of movies is 3, but there is/are only 1: "The Bourne Identity"

• No collection added (as expected)
  

[2024-07-17 23:09:44.684 -04:00] [INF] [8] Jellyfin.Plugin.TMDbBoxSets.TMDbBoxSetManager: Minimum number of movies is 3, but there is/are only 2: "The Bourne Identity, The Bourne Supremacy"

• Collection added, with no images (not as expected)
  

[2024-07-17 23:12:35.345 -04:00] [INF] [63] Jellyfin.Plugin.TMDbBoxSets.TMDbBoxSetManager: Minimum number of movies is 3, but there is/are only 2: "The Bourne Identity, The Bourne Supremacy"
[2024-07-17 23:22:12.918 -04:00] [INF] [45] Jellyfin.Plugin.TMDbBoxSets.ScheduledTasks.RefreshLibraryTask: Starting TMDbBoxSets refresh library task
[2024-07-17 23:22:14.758 -04:00] [INF] [45] Jellyfin.Plugin.TMDbBoxSets.TMDbBoxSetManager: Found 67 TMDb collection(s) across all movies
....
[2024-07-17 23:22:14.813 -04:00] [INF] [45] Jellyfin.Plugin.TMDbBoxSets.TMDbBoxSetManager: Minimum number of movies is 3, but there is/are only 2: "The Bourne Identity, The Bourne Supremacy"
[2024-07-17 23:22:15.400 -04:00] [INF] [45] Jellyfin.Plugin.TMDbBoxSets.ScheduledTasks.RefreshLibraryTask: TMDbBoxSets refresh library task finished
[2024-07-17 23:22:15.410 -04:00] [INF] [45] Emby.Server.Implementations.ScheduledTasks.TaskManager: "Scan library for new box sets" Completed after 0 minute(s) and 2 seconds

I'm running Jellyfin v10.9.6 on a Windows 7 Pro PC (SP1, 64-bit) (don't mock!); Jelly BoxSets version 11.0.0. (I've also deleted the v10 files from my computer, just in case)

I have a hacky workround (a batch file that deletes the relevant files in \Jellyfin\Server\data\collections\, but I have to run that every day!

Separately, I opened up Jellyfin.Plugin.TMDbBoxSets.dll in Notepad, and found the following text:

• $('#minimum-movies', page).val(config.MinimumNumberOfMovies || "2");
  
• config.MinimumNumberOfMovies = parseInt(minimumNumberOfMovies) || "2";
  

... so it looks like the plug-in isn't correctly obtaining the "minimum number of movies" setting (2 is the default).

[TheDreadPirate]

Looking at the code, it SHOULD be skipping those movies.

https://github.com/jellyfin/jellyfin-plu...ger.cs#L38

The log message indicates it is entering this if statement.

Code:

if (movies.Count < minimumNumberOfMovies)
            {
                _logger.LogInformation("Minimum number of movies is {Count}, but there is/are only {MovieCount}: {MovieNames}",
                    minimumNumberOfMovies, movies.Count, string.Join(", ", movies.Select(m => m.Name)));
                return;
            }

And the "return" should be returning to the caller and moving on to the next movie to evaluate.

Submit a bug report here.

https://github.com/jellyfin/jellyfin-plu...ets/issues

Once you've submitted your report, provide the link and I will comment confirming the bug as I was able to replicate your problem.

[tompw]

Done, thanks!

https://github.com/jellyfin/jellyfin-plu.../issues/81

[TheDreadPirate]

Did you submit? #81 404'd.

[tompw]

Yes - that's weird!

It's also listed top at https://github.com/jellyfin/jellyfin-plu...ets/issues

[TheDreadPirate]

It is not showing for me even though I'm a member of the Jellyfin git.

   

[tompw]

OK, it's there for me...

   

.... but it's not there when I sign out. Does my profile have to be approved in some way?

[theguymadmax]

I can't see the issue either. Best guess is that you have a private profile and that's affecting it??

[TheDreadPirate]

https://github.com/settings/profile

Is this box checked?  Not sure if this is the cause or not.

   

If this is a new account, did you fully verify it and your email address?

[tompw]

"Make profile private and hide activity" is unticked. (I ticked it, saved, then unticked, saved again)

Yes, it is a new account. I verified my email address (I had to do that when I signed up before I could do anything).

My profile is at https://github.com/tompwtompw ... but if I sign out, that gives a 404 error.

Is there some setting on the repo affecting things??

Btw, if someone wants to create this issue themselves, I will be fine with that! I'm more interested in getting the bug fixed than having a functioning GitHub account :-)