Media segments

[esvee]

The naming of the chapter segments can be arbitrary if you install the Chapter segment provider plugin.

This is the default naming for chapter segments.

Yes @theguymadmax, clients are setup to skip, but still aren't.

@TheDreadPirate , is the numbering I have a problem? if I ad " | commercial "to these defaults, nothing changes, clients still don't skip commercials.  Please see my screenshot     

Is this correct? if you can help with what its should be considering I have Commercial 1, Commercial 2 etc.

[TheDreadPirate]

After you add to the regex, I believe you need to re-run the "Media Segment Scan" job. I THINK it matches on any partial matches. So "commercial 1" SHOULD be fine.

---

I got clarification from the devs. You need to change the regex to commercial.*

It will NOT match on partial matches as is.

---

This can also work.

Code:

commercial\s\d{0,2}

[TheDreadPirate]

Another correction. It does do partial matches, just re-run the job for media segment scans.

[esvee]

I've tried all of these options now, and then for sanity put them all in. "commercial 1|commercial\s\d{0,2}|commercial|commercial.*"

Each time rerunning the job for media segment scans, even restarting jellyfin.

It makes no difference, the commercials never ask to skip, despite chapter markers being there. Confirmed Client settings are set to ask to skip. On Mac client (latest) and Web client.

Any other hints? Thanks so much for your help so far 👍🏻

[TheDreadPirate]

Try "replace all metadata" for the show.

[esvee]

Try "replace all metadata" for the show.

I'm afraid that didn't work either.  
I also tried using adjusting Intro skippers regex for "previews" with commercial regex options (as per above).  It doesn't work either.

Intros are skipping great! Is commercial skipping definitely confirmed to be working at the moment? or should I raise a bug on GitHub?

[Efficient_Good_5784]

It should be working.
I don't got any media with chapters named "commercial" that I know of on my end.

There already is a PR opened that will add "commercial" to the regex list by default as that was an obvious oversight when the defaults were first made.

The regex should still apply.
I would add a brand new file with a chapter marker named "commercial". I would then run the scheduled task to extract the segments.
This is just to test if the previous files were being skipped over after you added the new regex. Maybe it's not properly extracting the commercial segments from the new regex.

[esvee]

It should be working.
I don't got any media with chapters named "commercial" that I know of on my end.

There already is a PR opened that will add "commercial" to the regex list by default as that was an obvious oversight when the defaults were first made.

The regex should still apply.
I would add a brand new file with a chapter marker named "commercial". I would then run the scheduled task to extract the segments.
This is just to test if the previous files were being skipped over after you added the new regex. Maybe it's not properly extracting the commercial segments from the new regex.

Thanks for the suggestion.  I changed my comchap script to use "commercial" instead of its default "Commercial 1", "Commercial 2" etc.

In the chapter segment provider plugin settings, Regex pattern for commercials set to "break|ad|advertisement|intermission|commercial"

Now it's working. Thanks.